PTAL
http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java File user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java (right): http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java#newcode54 user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java:54: return method.invoke(this, args); On 2011/08/04 18:30:33, rjrjr wrote:
Is this really related to this patch? What's it fixing?
Removed. http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode505 user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:505: AutoBean<T> created; On 2011/08/04 18:30:33, rjrjr wrote:
So when I append the a CarService request context to a DogService
context, the
car context will know how to make dogs, yes? Are we sure that's
desirable?
I guess I'm asking if it's a side effect of the fix that is not worth
the work
of masking, or if you're taking extra effort to make it happen.
Presuming this side effect is happening because it needs to happen, we
should
explicitly test for it.
Changed createProxy() so that the user-accessible create() method isn't subject to cross-contamination. However, there are implementation limitations in the jre implementation that currently make this impractical. Filed issue 6658, since the difference in behavior can be eliminated after the RfValidator patch lands. I also changed createProxy() to be a protected method. http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java (right): http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java#newcode38 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java:38: * rechable proxy types. On 2011/08/04 18:30:33, rjrjr wrote:
reachable
Done. http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java#newcode91 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java:91: SimpleFooRequest c3 = c2.append(req.simpleFooRequest()); On 2011/08/04 18:30:33, rjrjr wrote:
Would be easier to read of the context names reflected their type.
barRc1,
fooRc1
Done. http://gwt-code-reviews.appspot.com/1499810/diff/3002/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1499810/diff/3002/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode107 user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:107: public Set<AbstractRequestContext> appendedContexts; Changed this to track the RequestContext instances since it's more general. http://gwt-code-reviews.appspot.com/1499810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
