I think you're right to keep this patch focussed on simply making the thing work again. Ugly as it is, this might be enough fixing to let us get 2.4 out the door.
But let's try to corner Dave for a chat on Monday before making that call, get his read on both the mvn structure and the Objectify usage. http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/pom.xml File samples/mobilewebapp/pom.xml (right): http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/pom.xml#newcode34 samples/mobilewebapp/pom.xml:34: <id>JBoss Repo</id> Do you still need this entry? http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/pom.xml#newcode73 samples/mobilewebapp/pom.xml:73: </dependency> Are user and dev really provided? I thought GPE backs off and relies on maven to download them. http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/pom.xml#newcode138 samples/mobilewebapp/pom.xml:138: <!-- Who is this for? What is it? --> While you're in here, did you try eliminating this and other "who is" items? http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/pom.xml#newcode174 samples/mobilewebapp/pom.xml:174: <!-- TODO: Who is using this? Is it just cruft from listwidget? --> ditto http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/pom.xml#newcode182 samples/mobilewebapp/pom.xml:182: <!-- TODO: Who is using this? Just GAE? Is anyone, really? --> etc. http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/pom.xml#newcode316 samples/mobilewebapp/pom.xml:316: <version>2.7</version> <!-- Note 2.8 does not work with AspectJ aspect path --> We don't care about AspectJ any more, right? Update this? http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/server/domain/Task.java File samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/server/domain/Task.java (right): http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/server/domain/Task.java#newcode50 samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/server/domain/Task.java:50: populateDatastore(); populateDatastore uses its own emf. Does the one in findAllTasks actually see the changes populateDatastore makes -- did you actually see the samples show up? http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/server/domain/Task.java#newcode69 samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/server/domain/Task.java:69: EMF emf = new EMF(); Is all of this new EMF() stuff safe and idiomatic Objectify? We don't need to try to use a single EMF per request or something? Sure feels wrong. http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/server/domain/Task.java#newcode232 samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/server/domain/Task.java:232: public void setVersion(Integer version) { I bet you can delete this. http://gwt-code-reviews.appspot.com/1521803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
