http://gwt-code-reviews.appspot.com/1463802/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (left):
http://gwt-code-reviews.appspot.com/1463802/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#oldcode204 dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:204: } If this was a private method, I'd say it was worth optimizing this. But the cost of iterating the units to make sure they are in the cache should be small (agreed?), and it keeps the contract of the method - if you don't ensure the cachedUnits are in allValidClasses, the method won't work. I have half a mind to get rid of setting allValidClasses from the other two places. http://gwt-code-reviews.appspot.com/1463802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
