http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java File samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java (right):
http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode79 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:79: * Example file. "Defines a custom table that displays a contact in each row. This is an example that shows how to completely customize the appearance of the headers, data rows, and footers in a CellTable." http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode143 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:143: * A custom header builder. "Renders custom headers that ..." http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode164 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:164: public void buildHeader(Helper<ContactInfo> utility) { s/utility/helper/ http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode209 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:209: * Build a single header. "Renders the header of one column, with the given options." http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode211 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:211: * @param utility the utility used to builder the header "used to build" http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode213 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:213: * @param header the header to buil "the Header to render" http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode220 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:220: private void buildHeader(Helper<ContactInfo> utility, TableRowBuilder tr, Header<?> header, rename utility -> helper rename tr -> out. Maybe reorder first arguments to match renderHeader() maybe rename to renderOneHeader()? http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode295 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:295: * A custom version of {@link CellTableBuilder}. "Renders the data rows that display each contact in the table." http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode489 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:489: * A map containing the IDs of {@link ContactInfo} who's friends list is "Contains the contact id for each row in the table where the friends list is currently expanded." http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java#newcode636 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java:636: * Initialize the column. "Defines the columns in the custom table. Maps the data in the ContactInfo for each row into the appropriate column in the table, and defines handlers for each column." http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java File user/src/com/google/gwt/user/cellview/client/HeaderCreator.java (right): http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode23 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:23: * Creates the header or footer section of a CellTable. "Creates the DOM elements for the header"... http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode32 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:32: public interface HeaderCreator<T> { Hmm, it seems like it should be HeaderBuilder to be consistent with TableBuilder? On the other hand, it doesn't actually create Header objects. Perhaps "HeaderRenderer" and "RowRenderer" might make more sense. http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode35 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:35: * A utility for building the header or footer. "Contains methods that {@link #buildHeader} can call while building a header or footer." http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode38 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:38: * The cell table being rendered will define the Utility implementation and s/Utility/Helper/ http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode73 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:73: public abstract void enabledColumnHandlers(ElementBuilderBase<?> builder, Column<T, ?> column); s/enabled/enable/ http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode78 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:78: public AbstractCellTable<T> getCellTable() { Could be just "getTable" http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode83 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:83: * Render a Header into the specified {@link ElementBuilderBase}. Use this "Renders a given Header into a given ElementBuilderBase. This method ensures that the CellTable widget will handle events " ... http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode90 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:90: * and must be in a state where a attributes and html can be added. "a state that allows both attributes and elements to be added." http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode91 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:91: * @param context the {@link Context} of the cell which cell? http://gwt-code-reviews.appspot.com/1499808/diff/14004/user/src/com/google/gwt/user/cellview/client/HeaderCreator.java#newcode116 user/src/com/google/gwt/user/cellview/client/HeaderCreator.java:116: void buildHeader(Helper<T> utility); s/utility/helper/ Maybe this should be named renderHeaders()? (I see in the example that it doesn't actually build the Header objects.) http://gwt-code-reviews.appspot.com/1499808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
