Reviewers: rjrjr, jlabanca, Message: Actual changes marked in the review, the rest is autoformatting.
The basis for this change is to prevent properties that depend on other collapsed properties from ballooning the number of hard (emitted) permutations. For example, the html5-related deferred binding properties prevent a simple <collapse-property name="user.agent" /> from actually reducing the number of permutations emitted. The rule: A dependency on a collapsed property forms an equivalence set for the dependent value. In other words, "Collapsing is contagious." http://gwt-code-reviews.appspot.com/1525804/diff/1/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java File dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java (right): http://gwt-code-reviews.appspot.com/1525804/diff/1/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java#newcode313 dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java:313: void normalizeCollapsedValues() { Actual change is here. http://gwt-code-reviews.appspot.com/1525804/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java File dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java (right): http://gwt-code-reviews.appspot.com/1525804/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode230 dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:230: public String toString() { Actual change here. Description: Collapse deferred-binding property values that depend on collapsed property values. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/1525804/ Affected files: M dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java M dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java M dev/core/test/com/google/gwt/dev/cfg/ModuleDefTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
