WidgetInterpreter and WidgetPlaceholderInterpreter shouldn't output LazyDomElement. Rafa, do you remember why? I don't think this aggregates any performance gain for us, am I missing something?
And I vote for #1 On Tue, Aug 16, 2011 at 10:10 PM, Rafael Castro <rdcas...@google.com> wrote: > +hermes > > Good point, this is really tricky. The problem here is that we don't > actually have the DOM element until the widget is attached. I see 2 options: > 1-) We force the UiField to be a LazyDomElement, so this is explicit. > 2-) We use PotentialElement with a resolver that throws an Exception (i.e., > it's only really resolved when it's attached). > > what do you think? > > ps.: really nice tests, thanks for putting them together! > > On Tue, Aug 16, 2011 at 5:13 PM, <rj...@google.com> wrote: > >> On 2011/08/17 00:12:24, rjrjr wrote: >> >> Ready for review. >> >> Rafa, this turned up one issue that concerns me: most @UiField fields >> are not filled in until the widget is attached to the dom, but we're not >> consistent about it. See the big comment in testDeep. >> >> >> http://gwt-code-reviews.**appspot.com/1527804/<http://gwt-code-reviews.appspot.com/1527804/> >> > > -- --Hermes Freitas -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
