LGTM. I like how simple the core diff is.
http://gwt-code-reviews.appspot.com/1520808/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryPolymorphicTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryPolymorphicTest.java (right): http://gwt-code-reviews.appspot.com/1520808/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryPolymorphicTest.java#newcode78 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryPolymorphicTest.java:78: Extra whitespace. http://gwt-code-reviews.appspot.com/1520808/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryPolymorphicTest.java#newcode701 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryPolymorphicTest.java:701: Extra whitespace here and elsewhere. http://gwt-code-reviews.appspot.com/1520808/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/1520808/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java#newcode715 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java:715: .getFooField()); Does selfOneToManyField have more than one element in it? If so, it would be good to double-check the length of the field and make ensure the globbing works on more than just the first element. http://gwt-code-reviews.appspot.com/1520808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
