http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java File user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java (right):
http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java#newcode60 user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java:60: if (!isParentOrRenderer(parentOrRoot, RENDERED_ATTRIBUTE)) { Should call the single arg version. This method is null tolerant. Should it NPE instead? If so, does that fix belong in isParentOrRenderer(Element, String)? http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java#newcode322 user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java:322: * Walks up the parents of the {@code rendered} element to ascertain that it is attached to the In DevMode, ... ... Always returns true in ProdMode http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/UiBinderUtil.java File user/src/com/google/gwt/uibinder/client/impl/UiBinderUtil.java (right): http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/UiBinderUtil.java#newcode28 user/src/com/google/gwt/uibinder/client/impl/UiBinderUtil.java:28: public class UiBinderUtil { As we discussed offline, it might not be the right time to make this move. But if you keep it, could you add a note to the issue tracker mentioning it as a breaking change (tag ReleaseNote=breakingChange) http://gwt-code-reviews.appspot.com/1534806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
