On 8 September 2011 09:41, Ray Ryan <rj...@google.com> wrote: > On Thu Sep 08 08:52:42 GMT-700 2011, <drfibona...@google.com> wrote: >> >> LGTM >> >> No changes needed. Nice Mavenizing! > > Thanks. I can copy and paste with the best of them. >> >> >> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/dynatablerf/pom.xml >> File samples/dynatablerf/pom.xml (right): >> >> >> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/dynatablerf/pom.xml#newcode26 >> samples/dynatablerf/pom.xml:26: <artifactId>gwt-servlet</artifactId> >> You could replace this with requestfactory-server as mobilewebapp now >> does, but this is fine (and actually useful in case of those using RF >> with RPC). > > Adding a comment to that effect >> >> >> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/mobilewebapp/pom.xml >> File samples/mobilewebapp/pom.xml (right): >> >> >> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/mobilewebapp/pom.xml#newcode160 >> samples/mobilewebapp/pom.xml:160: <!-- Unclear where these last two >> dependencies come from, >> They're required by Hibernate validator because slf4j-log4j is optional >> in the hibernate-validator POM > > So noted. >> >> http://gwt-code-reviews.appspot.com/1537803/ > > I'll submit this with the two tweaks mentioned above. After that I'd like to > clean up two more issues: > 1) [WARNING] Using platform encoding (MacRoman actually) to copy filtered > resources, i.e. build is platform dependent!
<properties> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> </properties> > 2) [ERROR] log4j:WARN Please initialize the log4j system properly. Add a log4j.xml or log4j.properties to src/main/resources. > Do you know what incantations are needed to quiet those? > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
