I'm a bit late but: Note that it fixes http://code.google.com/p/google-web-toolkit/issues/detail?id=4940
http://gwt-code-reviews.appspot.com/1586804/diff/1/user/src/com/google/gwt/http/client/UrlBuilder.java File user/src/com/google/gwt/http/client/UrlBuilder.java (right): http://gwt-code-reviews.appspot.com/1586804/diff/1/user/src/com/google/gwt/http/client/UrlBuilder.java#newcode53 user/src/com/google/gwt/http/client/UrlBuilder.java:53: url.append(URL.encode(protocol)).append("://"); Maybe should rather be URL.encodeComponent(protocol, false), or, as it's deprecated, URL.encodePathComponent(protocol). http://gwt-code-reviews.appspot.com/1586804/diff/1/user/src/com/google/gwt/http/client/UrlBuilder.java#newcode76 user/src/com/google/gwt/http/client/UrlBuilder.java:76: .append(URL.encodeQueryString(entry.getKey())) encodePathSegment is faster, as is won't change %20 to + (which is done in a second pass). As an alternative, if we really want +s for spaces in the query-string, appending to another StringBuilder using encodePathSegment, and then replacing /%20/g with + before appending to the 'url' StringBuilder would be faster than encodeQueryString as done here. But maybe this is premature optimization? http://gwt-code-reviews.appspot.com/1586804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
