LGTM, but see comment below.
http://gwt-code-reviews.appspot.com/1601803/diff/9/user/src/com/google/gwt/user/client/ui/ScrollImpl.java File user/src/com/google/gwt/user/client/ui/ScrollImpl.java (right): http://gwt-code-reviews.appspot.com/1601803/diff/9/user/src/com/google/gwt/user/client/ui/ScrollImpl.java#newcode73 user/src/com/google/gwt/user/client/ui/ScrollImpl.java:73: // initialize static, leak-safe scroll/resize handlers Correct me if I'm wrong but there's chance it could leak if the compiler inlines initHandlers here. Calling it from the constructor or static initializer we'd be assured it's not inlined (AFAICT) so that there won't be any element in-scope to trigger a leak. Static initializer would introduce a clinit so it's not a good idea IMO. So either a constructor, or an explicit init() call from ScrollImpl.get() below (with a no-op method in ScrollImpl for the non-IE case) http://gwt-code-reviews.appspot.com/1601803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
