Note also that sometimes we have to rollback or patch something in an emergency that has broken important internal apps, so we will often rollback or quickfix these without the regular delay of going through the public issue tracker, but hopefully these are rare instances.
-Ray On Wed, Dec 7, 2011 at 1:08 PM, John Tamplin <[email protected]> wrote: > On Wed, Dec 7, 2011 at 3:58 PM, karthik reddy <[email protected]> > wrote: >> >> I have tacitly presumed that a LGTM from the reviewers is kinda >> mandatory for a commit to be made. However, I have just noticed a commit >> made today without a explicit LGTM. > > > Since GWT code is committed to an internal system which also requires an > LGTM, jlabanca approved it there and just didn't put the LGTM on the public > review. > > -- > John A. Tamplin > Software Engineer (GWT), Google > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
