http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right):
http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode187 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:187: enum InstrumentationMode { Is CUSTOM implemented? I'm not seeing it. http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode624 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:624: private JsVars immortalJsVars; The lifecycle of this variable is a bit unclear to me. Maybe add a comment? http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode778 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:778: // Don't instrument the Stats function, it is referenced from within the instrument code line too long http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode779 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:779: && names.get(program.getIndexedMethod("Stats.isStatsAvailable")) != func.getName()) { do we know these objects are interned? http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode1342 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:1342: Iterator<JsVar> varIt = immortalJsVars.iterator(); maybe add a new method to JsVars, so this is: vars.addAll(immortalJsVars); http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Instrumentation.java File dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Instrumentation.java (right): http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Instrumentation.java#newcode34 dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Instrumentation.java:34: onExit(); What about exiting via an exception? http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Instrumentation.java#newcode39 dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Instrumentation.java:39: public static native JavaScriptObject profileFunction(JavaScriptObject toProfile, String name) /*-{ javadoc? http://gwt-code-reviews.appspot.com/1614804/diff/1/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Instrumentation.java#newcode47 dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Instrumentation.java:47: public static void profileEnter(String methodName) { style nit: how about onMethodEnter, onMethodExit http://gwt-code-reviews.appspot.com/1614804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
