http://gwt-code-reviews.appspot.com/1619803/diff/1/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java File user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java (left):
http://gwt-code-reviews.appspot.com/1619803/diff/1/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java#oldcode68 user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java:68: public void xx_testExtraValueSet() { // TODO(rjrjr) Strange failures on firefox Before I added the NPE check, I removed these xx_ prefixes and the tests were indeed failing. However, after adding the NPE check, they all now pass. The last test, testNormalSetWithKeyProvider, was even causing the same NPE from the issue tracker, so I did not need to add a new test to reproduce it. Seems slightly odd than a missing NPE check would cause failures specifically on Firefox, per Ray's comment; but they pass now. http://gwt-code-reviews.appspot.com/1619803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
