http://gwt-code-reviews.appspot.com/1615804/diff/1/user/src/com/google/gwt/user/client/ui/DeckLayoutPanel.java
File user/src/com/google/gwt/user/client/ui/DeckLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/1615804/diff/1/user/src/com/google/gwt/user/client/ui/DeckLayoutPanel.java#newcode201
user/src/com/google/gwt/user/client/ui/DeckLayoutPanel.java:201: public
void onLoad() {
On 2011/12/19 15:29:36, jlabanca wrote:
These should probably go in onAttach/onDetach instead of
onLoad/onUnload.  Users
may not call super.onLoad/onUnload, but if you override
onAttach/onDetach you
must call the super methods.

You might want to change DockLayoutPanel, SimpleLayoutPanel,
CustomScrollPanel and LayoutPanel, which all use onLoad. Actually, only
ResizeLayoutPanel uses onAttach.

IMO, users *should* call super.onLoad unless they're directly extending
Widget.

http://gwt-code-reviews.appspot.com/1615804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to