LGTM
http://gwt-code-reviews.appspot.com/1618806/diff/2001/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1618806/diff/2001/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode274 user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:274: sb.append(nonCollectionEncode(it.next())); On 2011/12/20 15:55:56, rdayal wrote:
On 2011/12/20 10:51:18, tbroyer wrote: > Using encode() here would pave the way for supporting collections of collections > (see issue 5974). > You'd then turn the RuntimeException in nonCollectionEncode into a
simple
> 'assert'. > I mean, in the case of JsonRpc, GWT doesn't provide the backend, so
there's
> theoretically no reason to disallow collections of collections,
except for
> parity with the "standard" RF protocol. Agreed, but I'd rather put a TODO here and then fix 5974 on both sides
- is that
ok with you?
Yep. http://gwt-code-reviews.appspot.com/1618806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
