I am one of these guys who loves to have a null value in a ListBox to be 
able to "deselect" things in a ListBox.

So my server just gives me "a,b,c" and I call setAcceptableValues() with 
this list without any call to setValue() before (new view, activity loads 
list of acceptable values and just sets them). ValueListBox now appends 
null at the end and in my renderer I check for null and render it like 
"please choose" or something. Wouldn't this patch break the app behavior 
for everyone that has implemented it like this? Because with this patch 
ValueListBox would select "a" and I am not able to deselect anything 
anymore. I don't think its uncommon.

Anyways maybe my app isn't affected anymore to this patch because I decided 
that its nicer to have the "null" selection at the beginning of my entries 
in ValueListBox. So nowadays I add "null" at the beginning of the list of 
acceptable values. So my List now contains null anyways.

Until now I don't even recognized that setValue() actually adds and select 
a value to the ValueListBox if its not in acceptable values. I never really 
read the JavaDoc on setValue because if I see two methods: 
setAcceptableValues() and setValue() I assume that setValue() can only take 
values that are defined by setAcceptableValues(), otherwise it will do 
nothing or throw an exception. So it seems a bit strange to merge both. I 
guess the idea of merging acceptable values with the selected value is the 
root issue here.

-- J


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to