On 2011/12/21 16:23:03, jat wrote:
The idea and initial implementation looks good, but most of the
complexity and
implementation details are due to cross-browser issues.  In
particular, we left
out functionality that we couldn't implement consistently across all
browsers,
and my recollection is that this was one of those cuts.

It is possible that has changed now, or that the set of browsers that
don't
support it is small enough we can add it with documentation explaining
when it
can't be used, but it definitely needs extensive testing across the
full range
of browsers GWT supports.

See
http://closure-library.googlecode.com/svn/docs/closure_goog_history_history.js.source.html#line620
Also, the file documentation (at the very beginning of the file)
contains extensive information on browser behaviors.

Apparently, in the case of IE, it uses doc.open('text/html', 'replace')
for replaceToken, instead of doc.open('text/html') for setToken.

BTW, comment at
http://closure-library.googlecode.com/svn/docs/closure_goog_history_history.js.source.html#line613
is interesting (re. our HistoryImplMozilla vs. others; maybe this should
be moved up to HistoryImpl?)

http://gwt-code-reviews.appspot.com/1614809/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to