LGTM with some nits

one day i'll make a pass through all this code to make it style
conformant, but for now just trying to avoid more style violations.
(technically the column limit should be 80, but we'll keep 100 within
this code for consistency for now...)


http://gwt-code-reviews.appspot.com/1620803/diff/10001/plugins/common/InvokeSpecialMessage.h
File plugins/common/InvokeSpecialMessage.h (right):

http://gwt-code-reviews.appspot.com/1620803/diff/10001/plugins/common/InvokeSpecialMessage.h#newcode44
plugins/common/InvokeSpecialMessage.h:44:
InvokeSpecialMessage(SessionHandler::SpecialMethodId dispatchId, int
numArgs, const gwt::Value* args) :
still over 100 chars

http://gwt-code-reviews.appspot.com/1620803/diff/10001/plugins/common/SessionHandler.h
File plugins/common/SessionHandler.h (right):

http://gwt-code-reviews.appspot.com/1620803/diff/10001/plugins/common/SessionHandler.h#newcode89
plugins/common/SessionHandler.h:89: gwt::Value* returnValue)=0;
nit: ' = 0;'

http://gwt-code-reviews.appspot.com/1620803/diff/10001/plugins/common/Value.h
File plugins/common/Value.h (right):

http://gwt-code-reviews.appspot.com/1620803/diff/10001/plugins/common/Value.h#newcode399
plugins/common/Value.h:399: // namespace gwt
the comment must be adjacent to the closing bracket:

e.g.:

} // namespace gwt

http://gwt-code-reviews.appspot.com/1620803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to