http://gwt-code-reviews.appspot.com/1671803/diff/1/user/src/com/google/gwt/user/client/ui/UIObject.java
File user/src/com/google/gwt/user/client/ui/UIObject.java (right):

http://gwt-code-reviews.appspot.com/1671803/diff/1/user/src/com/google/gwt/user/client/ui/UIObject.java#newcode246
user/src/com/google/gwt/user/client/ui/UIObject.java:246: * {@code
setVisible(elem, true)}.
I don't think the last sentence is accurate (but I could be wrong_.
Setting the style to '' should clear the display: none in CSS.

http://gwt-code-reviews.appspot.com/1671803/diff/1/user/test/com/google/gwt/user/client/ui/UIObjectTest.java
File user/test/com/google/gwt/user/client/ui/UIObjectTest.java (right):

http://gwt-code-reviews.appspot.com/1671803/diff/1/user/test/com/google/gwt/user/client/ui/UIObjectTest.java#newcode228
user/test/com/google/gwt/user/client/ui/UIObjectTest.java:228: public
void testIsVisible_displayNone() {
This test is the same as the one above.  And its name indicates you
meant to do what you did in testIsVisible_hidden

http://gwt-code-reviews.appspot.com/1671803/diff/1/user/test/com/google/gwt/user/client/ui/UIObjectTest.java#newcode242
user/test/com/google/gwt/user/client/ui/UIObjectTest.java:242:
State.HIDDEN.set(elem, false);
If you are testing that you ignore the aria attribute, shouldn't this be
State.HIDDEN.set(elem, true)

http://gwt-code-reviews.appspot.com/1671803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to