Updated.
http://gwt-code-reviews.appspot.com/1711804/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/1711804/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java#newcode1280 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:1280: SymbolData[] r = new SymbolData[result.size()]; On 2012/05/23 08:56:01, tbroyer wrote:
Could be simplified to: return result.toArray(new SymbolData[result.size()]);
Done. http://gwt-code-reviews.appspot.com/1711804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/VerifySymbolMap.java File dev/core/src/com/google/gwt/dev/jjs/impl/VerifySymbolMap.java (right): http://gwt-code-reviews.appspot.com/1711804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/VerifySymbolMap.java#newcode43 dev/core/src/com/google/gwt/dev/jjs/impl/VerifySymbolMap.java:43: public VerifySymbolMap( On 2012/05/23 08:56:01, tbroyer wrote:
Should it be 'private' ?
Done. http://gwt-code-reviews.appspot.com/1711804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/VerifySymbolMap.java#newcode57 dev/core/src/com/google/gwt/dev/jjs/impl/VerifySymbolMap.java:57: public static void exec(JsProgram jsProgram, JavaToJavaScriptMap jjsmap, On 2012/05/23 08:56:01, tbroyer wrote:
IIRC, static members should appear before instance members in our
style guide. You are right. I usually let the pre-submit script tells me what goes where when I submit. http://gwt-code-reviews.appspot.com/1711804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/VerifySymbolMap.java#newcode63 dev/core/src/com/google/gwt/dev/jjs/impl/VerifySymbolMap.java:63: accept(jsProgram); On 2012/05/23 08:56:01, tbroyer wrote:
Given that jsProgram is only used here, could we remove the field and
that
method? and change exec() to: new VerifySymbolMap(jjsmap, symbolTable).accept(jsProgram);
good call. http://gwt-code-reviews.appspot.com/1711804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
