On 2012/05/25 22:53:18, tbroyer wrote:
On 2012/05/25 17:58:21, skybrian wrote:
>
> In getEditors: "The returned
> list will be live until the next call to setValue() and shouldn't be
> used after that."

[...]

> Yeah, #3 is out. Option #2 would make sense if we expected that
> complaining early means that most people would fix the problem
before
> it reaches production. I'm not convinced of that; I think people
won't
> test the corner cases that result in null list fields in their
> AutoBeans (particularly if those corner cases come from the server).

AFAICT, that's already an issue with other editors though: in the
DevGuide for
editors [1], if the "address" or "manager" is null, then you'll have
an NPE at
runtime.

Hey, know what? I was wrong!

If the 'address' is 'null', it'll set 'null' to the AddressEditor (if
it's a ValueAwareEditor) and all of its sub-editors.

So #1 (what we do here) is actually exactly what we *should* do!

http://gwt-code-reviews.appspot.com/1664803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to