[gwt-contrib] Re: Checkstyle fixes (issue1565806)

Wed, 06 Jun 2012 20:07:26 -0700 

Reviewers: rjrjr, rdayal, rchandia,

Message:


Please keep the license header as it was before.


Done.



Please review this at http://gwt-code-reviews.appspot.com/1565806/

Affected files:
M dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java 
  M dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
  M user/src/com/google/gwt/geolocation/client/Position.java
  M user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
M user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java 
  M user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
M user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java 
  M user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
  M user/test/com/google/gwt/editor/client/DirtyEditorTest.java
  M user/test/com/google/gwt/emultest/java/util/TreeMapTest.java
  M user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java
Index: dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java diff --git a/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java b/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java index 5df3c26269f08649a4de37e9c05aa538b7a78be9..9111d097fb25758db53d3e72f2c00d70abe66554 100644 --- a/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java +++ b/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java @@ -84,7 +84,7 @@ public class StandardPublicResource extends PublicResource { 
     try {
       return resource.openContents();
     } catch (IOException ex) {
- logger.log (TreeLogger.ERROR, "Problem reading resource: " + resource.getLocation(), ex); + logger.log(TreeLogger.ERROR, "Problem reading resource: " + resource.getLocation(), ex); 
       throw new UnableToCompleteException();
     }
   }
Index: dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
diff --git a/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java b/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java index 36cb77753045ea98ff722d71bc63bee732a0756d..c3fe75cd64217800ffaf4012adb7019bc21d6438 100644 
--- a/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
+++ b/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
@@ -179,8 +179,7 @@ public class BindingProperty extends Property {
         LinkedList<String> childList = fallbackValues.get(from);
         LinkedHashSet<String> children = new LinkedHashSet<String>();
         children.addAll(childList);
-        while (children != null && children.size() > 0)
-        {
+        while (children != null && children.size() > 0) {
           alternates.add(children);
           LinkedHashSet<String> newChildren = new LinkedHashSet<String>();
           for (String child : children) {
Index: user/src/com/google/gwt/geolocation/client/Position.java
diff --git a/user/src/com/google/gwt/geolocation/client/Position.java b/user/src/com/google/gwt/geolocation/client/Position.java index 88c51294b4c6f71ed5e731f2e1483e85c0ea6884..477d3b3fbb54a4f1a7127095e3c755e577a12da2 100644 
--- a/user/src/com/google/gwt/geolocation/client/Position.java
+++ b/user/src/com/google/gwt/geolocation/client/Position.java
@@ -28,12 +28,12 @@ public interface Position {
   /**
    * Returns information about the coordinates reported by the browser.
    */
-  public Coordinates getCoordinates();
+  Coordinates getCoordinates();

   /**
    * Returns the time this position was reported by the browser.
    */
-  public double getTimestamp();
+  double getTimestamp();

   /**
    * Represents position reported by the browser.
@@ -44,7 +44,7 @@ public interface Position {
     /**
      * Returns the estimated accuracy reported by the browser, in meters.
      */
-    public double getAccuracy();
+    double getAccuracy();

     /**
* Returns the altitude reported by the browser, in meters, above the <a 
@@ -52,37 +52,37 @@ public interface Position {
      * ellipsoid</a>, or <code>null</code> if the browser did not report an
      * altitude.
      */
-    public Double getAltitude();
+    Double getAltitude();

     /**
* Returns the estimated accuracy of the altitude reported by the browser, 
      * in meters, or <code>null</code> if the browser did not report an
      * accuracy.
      */
-    public Double getAltitudeAccuracy();
+    Double getAltitudeAccuracy();

     /**
* Returns the heading, in degrees from due north, reported by the browser, * based on previous calls to get the user's position, or <code>null</code> 
      * if the browser did not report a heading.
      */
-    public Double getHeading();
+    Double getHeading();

     /**
      * Returns the decimal latitude reported by the browser.
      */
-    public double getLatitude();
+    double getLatitude();

     /**
      * Returns the decimal longitude reported by the browser.
      */
-    public double getLongitude();
+    double getLongitude();

     /**
* Returns the speed, in meters/second, reported by the browser, based on * previous calls to get the user's position, or <code>null</code> if the 
      * browser did not report a speed.
      */
-    public Double getSpeed();
+    Double getSpeed();
   }
 }
Index: user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
diff --git a/user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java b/user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java index 5ea05912b37b577c3f4a7225b5519916462b1549..d68729822ac5b73bd7f4d1938dbfb03351c84c02 100644 
--- a/user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
+++ b/user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
@@ -24,7 +24,7 @@ public interface AlternateMessageSelector {
   /**
    * Name of the "other" form.
    */
-  public static final String OTHER_FORM_NAME = "other";
+  String OTHER_FORM_NAME = "other";

   /**
    * Represents an alternate form of a message.
Index: user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java diff --git a/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java b/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java index ca4c183d4587a7eaf973ce8c665d8534d95981d9..f2c58d561e7e3ecd18e41045691b97d264752712 100644 --- a/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java +++ b/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java @@ -290,7 +290,7 @@ public final class ClientSerializationStreamReader extends 

   @Override
   public long readLong() {
- return LongLib.longFromBase64(((JsStringLiteral)decoder.getValues().get(--index)).getValue()); + return LongLib.longFromBase64(((JsStringLiteral) decoder.getValues().get(--index)).getValue()); 
   }

   @Override
Index: user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java diff --git a/user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java b/user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java index 286d11f81930419224c904f13eb512d407bc98b9..857d67afa6fa8f7b5d7183920bc77b1a13fc4b4a 100644 
--- a/user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
+++ b/user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
@@ -162,7 +162,7 @@ public abstract class BaseMessageInterpolator implements MessageInterpolator { 
     return sb.toString();
   }

-  private final String removeCurlyBrace(String parameter) {
+  private String removeCurlyBrace(String parameter) {
     return parameter.substring(1, parameter.length() - 1);
   }
 }
Index: user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java diff --git a/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java b/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java index b9dc703678dba8ccb9b1896c8a1e58e81b83bd17..3d4d2c3c4f44e1a9639ce675711dc07faa1c2353 100644 --- a/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java +++ b/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java 
@@ -30,7 +30,7 @@ import java.util.Map;
  */
 public class CountingEventBus extends EventBus {
private final KeyedCounter<Type<?>> handlerCounts = new KeyedCounter<Event.Type<?>>(); - private final KeyedCounter<Type<?>> firedCounts = new KeyedCounter<Event.Type<?>> (); + private final KeyedCounter<Type<?>> firedCounts = new KeyedCounter<Event.Type<?>>(); private final KeyedCounter<TypeSourcePair> sourceCounts = new KeyedCounter<TypeSourcePair>(); 
   private final EventBus wrapped;
Index: user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java diff --git a/user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java b/user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java index bd62651b632e6e9d4b6321df177687856bdc9e28..f7b079f779d25c070b871e989f48a110e2949c36 100644 
--- a/user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
+++ b/user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
@@ -128,7 +128,7 @@ public class TypeHierarchyTest extends GWTTestCase {

   private static class JvmNode implements Node {
     public JvmNode appendChild(Node node) {
-      return (JvmNode)node;
+      return (JvmNode) node;
     }
   }

Index: user/test/com/google/gwt/editor/client/DirtyEditorTest.java
diff --git a/user/test/com/google/gwt/editor/client/DirtyEditorTest.java b/user/test/com/google/gwt/editor/client/DirtyEditorTest.java index a17a65c72c6545a74ec787f6cbd771e962e7c3dc..823c53637e5c02529d187ab04b2e1e7116ae806f 100644 
--- a/user/test/com/google/gwt/editor/client/DirtyEditorTest.java
+++ b/user/test/com/google/gwt/editor/client/DirtyEditorTest.java
@@ -98,9 +98,10 @@ public class DirtyEditorTest extends GWTTestCase {
     person.address = null;

     AddressEditor addressEditor = new AddressEditor();
- PersonEditorWithOptionalAddressEditor editor = new PersonEditorWithOptionalAddressEditor( 
-        addressEditor);
- PersonEditorWithOptionalAddressDriver driver = GWT.create(PersonEditorWithOptionalAddressDriver.class); 
+    PersonEditorWithOptionalAddressEditor editor =
+        new PersonEditorWithOptionalAddressEditor(addressEditor);
+    PersonEditorWithOptionalAddressDriver driver =
+        GWT.create(PersonEditorWithOptionalAddressDriver.class);
     driver.initialize(editor);
     driver.edit(person);

@@ -177,23 +178,21 @@ public class DirtyEditorTest extends GWTTestCase {
   }
   class WorkgroupEditor implements Editor<Workgroup> {
     SimpleEditor<String> label = SimpleEditor.of();
- OptionalFieldEditor<List<Person>, ListEditor<Person, PersonEditor>> people = // 
-    OptionalFieldEditor.of(ListEditor.<Person, PersonEditor> of( //
-    new EditorSource<PersonEditor>() {
-      @Override
-      public PersonEditor create(int index) {
-        return new PersonEditor();
-      }
-    }));
+ OptionalFieldEditor<List<Person>, ListEditor<Person, PersonEditor>> people = + OptionalFieldEditor.of(ListEditor.of(new EditorSource<PersonEditor>() { 
+          @Override
+          public PersonEditor create(int index) {
+            return new PersonEditor();
+          }
+        }));
   }

-  interface WorkgroupEditorDriver extends
-      SimpleBeanEditorDriver<Workgroup, WorkgroupEditor> {
+ interface WorkgroupEditorDriver extends SimpleBeanEditorDriver<Workgroup, WorkgroupEditor> { 
   }

   /**
- * CompositeEditors have an implementation complication due to the EditorChain 
-   * needing to patch the composite editors into the hierarchy.
+ * CompositeEditors have an implementation complication due to the EditorChain needing to patch 
+   * the composite editors into the hierarchy.
    */
   public void testDirtyOptionalList() {
     WorkgroupEditorDriver driver = GWT.create(WorkgroupEditorDriver.class);
Index: user/test/com/google/gwt/emultest/java/util/TreeMapTest.java
diff --git a/user/test/com/google/gwt/emultest/java/util/TreeMapTest.java b/user/test/com/google/gwt/emultest/java/util/TreeMapTest.java index 94a3b44df1ffe3d44eae07c2068d42d47123c472..a7222192634a3cb69476929393a6a94c145e2716 100644 
--- a/user/test/com/google/gwt/emultest/java/util/TreeMapTest.java
+++ b/user/test/com/google/gwt/emultest/java/util/TreeMapTest.java
@@ -85,7 +85,7 @@ public abstract class TreeMapTest<K extends Comparable<K>, V> extends TestMap { 
     }

     @Override
-    public final V setValue(V value) {
+    public V setValue(V value) {
       throw new UnsupportedOperationException();
     }
   }
Index: user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java
diff --git a/user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java b/user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java index ee1f40d36c2a579431729e60cf8108772136fc01..76f155b34ec31e71fdd3b02321d317c138ad4ff2 100644 
--- a/user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java
+++ b/user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java
@@ -527,7 +527,7 @@ public class RPCTypeCheckTest extends TestCase {
    * Test interface for multiple wildcard bounds.
    */
   public interface MInterface<X> {
-    public X echo(X arg);
+    X echo(X arg);
   }

   /**


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to