On Thursday, June 7, 2012 9:44:04 PM UTC+2, Stephen Haberman wrote: > > Hey, > > Digging around today, I noticed that awhile ago isOrHasChild was > specialized per-browser, but not for webkit/safari due to at that time > (2008/safari2) a bug in safari's contains: > > http://code.google.com/p/google-web-toolkit/source/detail?r=1829# > > Since then it looks like Safari's implementation has been > fixed--one of jquery's "contains" implementations doesn't even check > for safari2, and this other one falls back to tree walk (like GWT does > now for all webkits) only for safari2 but otherwise uses contains: > > http://bugs.jquery.com/attachment/ticket/2477/safari_contains_2477.diff > > (I am admittedly blindly trusting the "< 522" version check in this > diff; I haven't tracked it back to the original safari/webkit bug.) > > Is this something worth updating DOMImplSafari for? > > It is not really affecting me, I just noticed it while debugging some > mouse events, specifically: > > http://code.google.com/p/google-web-toolkit/issues/detail?id=943 > > AFAICT, Safari 2 is no longer part of the supported browsers list, so my take on it would be to clean-up the codebase and remove every safari2-specific path. There are overall a lot of cleanup (remove event listeners for instance, which have been deprecated for several *years*)
-- http://groups.google.com/group/Google-Web-Toolkit-Contributors
