Reviewers: rdayal,
Description:
Checkstyle fixes
Repost of 1565806
Thanks Stephen!
Patch by: [email protected]
Please review this at http://gwt-code-reviews.appspot.com/1725807/
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
M dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
M user/src/com/google/gwt/geolocation/client/Position.java
M user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
M
user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java
M user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
M
user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java
M user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
M user/test/com/google/gwt/editor/client/DirtyEditorTest.java
M user/test/com/google/gwt/emultest/java/util/TreeMapTest.java
M user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java
Index:
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
===================================================================
---
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
(revision 11026)
+++
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
(working copy)
@@ -84,7 +84,7 @@
try {
return resource.openContents();
} catch (IOException ex) {
- logger.log (TreeLogger.ERROR, "Problem reading resource: " +
resource.getLocation(), ex);
+ logger.log(TreeLogger.ERROR, "Problem reading resource: " +
resource.getLocation(), ex);
throw new UnableToCompleteException();
}
}
Index: dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
===================================================================
--- dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java (revision
11026)
+++ dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java (working copy)
@@ -179,8 +179,7 @@
LinkedList<String> childList = fallbackValues.get(from);
LinkedHashSet<String> children = new LinkedHashSet<String>();
children.addAll(childList);
- while (children != null && children.size() > 0)
- {
+ while (children != null && children.size() > 0) {
alternates.add(children);
LinkedHashSet<String> newChildren = new LinkedHashSet<String>();
for (String child : children) {
Index: user/src/com/google/gwt/geolocation/client/Position.java
===================================================================
--- user/src/com/google/gwt/geolocation/client/Position.java (revision
11026)
+++ user/src/com/google/gwt/geolocation/client/Position.java (working copy)
@@ -28,12 +28,12 @@
/**
* Returns information about the coordinates reported by the browser.
*/
- public Coordinates getCoordinates();
+ Coordinates getCoordinates();
/**
* Returns the time this position was reported by the browser.
*/
- public double getTimestamp();
+ double getTimestamp();
/**
* Represents position reported by the browser.
@@ -44,7 +44,7 @@
/**
* Returns the estimated accuracy reported by the browser, in meters.
*/
- public double getAccuracy();
+ double getAccuracy();
/**
* Returns the altitude reported by the browser, in meters, above the
<a
@@ -52,37 +52,37 @@
* ellipsoid</a>, or <code>null</code> if the browser did not report an
* altitude.
*/
- public Double getAltitude();
+ Double getAltitude();
/**
* Returns the estimated accuracy of the altitude reported by the
browser,
* in meters, or <code>null</code> if the browser did not report an
* accuracy.
*/
- public Double getAltitudeAccuracy();
+ Double getAltitudeAccuracy();
/**
* Returns the heading, in degrees from due north, reported by the
browser,
* based on previous calls to get the user's position, or
<code>null</code>
* if the browser did not report a heading.
*/
- public Double getHeading();
+ Double getHeading();
/**
* Returns the decimal latitude reported by the browser.
*/
- public double getLatitude();
+ double getLatitude();
/**
* Returns the decimal longitude reported by the browser.
*/
- public double getLongitude();
+ double getLongitude();
/**
* Returns the speed, in meters/second, reported by the browser, based
on
* previous calls to get the user's position, or <code>null</code> if
the
* browser did not report a speed.
*/
- public Double getSpeed();
+ Double getSpeed();
}
}
Index: user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
===================================================================
--- user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
(revision 11026)
+++ user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
(working copy)
@@ -24,7 +24,7 @@
/**
* Name of the "other" form.
*/
- public static final String OTHER_FORM_NAME = "other";
+ String OTHER_FORM_NAME = "other";
/**
* Represents an alternate form of a message.
Index:
user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java
===================================================================
---
user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java
(revision 11026)
+++
user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java
(working copy)
@@ -375,7 +375,7 @@
@Override
public long readLong() {
- return
LongLib.longFromBase64(((JsStringLiteral)decoder.getValues().get(--index)).getValue());
+ return LongLib.longFromBase64(((JsStringLiteral)
decoder.getValues().get(--index)).getValue());
}
@Override
Index:
user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
===================================================================
--- user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
(revision 11026)
+++ user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
(working copy)
@@ -139,7 +139,7 @@
return sb.toString();
}
- private final String removeCurlyBrace(String parameter) {
+ private String removeCurlyBrace(String parameter) {
return parameter.substring(1, parameter.length() - 1);
}
}
Index:
user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java
===================================================================
---
user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java
(revision 11026)
+++
user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java
(working copy)
@@ -30,7 +30,7 @@
*/
public class CountingEventBus extends EventBus {
private final KeyedCounter<Type<?>> handlerCounts = new
KeyedCounter<Event.Type<?>>();
- private final KeyedCounter<Type<?>> firedCounts = new
KeyedCounter<Event.Type<?>> ();
+ private final KeyedCounter<Type<?>> firedCounts = new
KeyedCounter<Event.Type<?>>();
private final KeyedCounter<TypeSourcePair> sourceCounts = new
KeyedCounter<TypeSourcePair>();
private final EventBus wrapped;
Index:
user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
===================================================================
--- user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
(revision 11026)
+++ user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
(working copy)
@@ -128,7 +128,7 @@
private static class JvmNode implements Node {
public JvmNode appendChild(Node node) {
- return (JvmNode)node;
+ return (JvmNode) node;
}
}
Index: user/test/com/google/gwt/editor/client/DirtyEditorTest.java
===================================================================
--- user/test/com/google/gwt/editor/client/DirtyEditorTest.java (revision
11026)
+++ user/test/com/google/gwt/editor/client/DirtyEditorTest.java (working
copy)
@@ -98,9 +98,10 @@
person.address = null;
AddressEditor addressEditor = new AddressEditor();
- PersonEditorWithOptionalAddressEditor editor = new
PersonEditorWithOptionalAddressEditor(
- addressEditor);
- PersonEditorWithOptionalAddressDriver driver =
GWT.create(PersonEditorWithOptionalAddressDriver.class);
+ PersonEditorWithOptionalAddressEditor editor =
+ new PersonEditorWithOptionalAddressEditor(addressEditor);
+ PersonEditorWithOptionalAddressDriver driver =
+ GWT.create(PersonEditorWithOptionalAddressDriver.class);
driver.initialize(editor);
driver.edit(person);
@@ -177,23 +178,22 @@
}
class WorkgroupEditor implements Editor<Workgroup> {
SimpleEditor<String> label = SimpleEditor.of();
- OptionalFieldEditor<List<Person>, ListEditor<Person, PersonEditor>>
people = //
- OptionalFieldEditor.of(ListEditor.<Person, PersonEditor> of( //
- new EditorSource<PersonEditor>() {
- @Override
- public PersonEditor create(int index) {
- return new PersonEditor();
- }
- }));
- }
-
- interface WorkgroupEditorDriver extends
- SimpleBeanEditorDriver<Workgroup, WorkgroupEditor> {
+ OptionalFieldEditor<List<Person>, ListEditor<Person, PersonEditor>>
people =
+ OptionalFieldEditor.of(ListEditor
+ .<Person, PersonEditor> of(new EditorSource<PersonEditor>() {
+ @Override
+ public PersonEditor create(int index) {
+ return new PersonEditor();
+ }
+ }));
+ }
+
+ interface WorkgroupEditorDriver extends
SimpleBeanEditorDriver<Workgroup, WorkgroupEditor> {
}
/**
- * CompositeEditors have an implementation complication due to the
EditorChain
- * needing to patch the composite editors into the hierarchy.
+ * CompositeEditors have an implementation complication due to the
EditorChain needing to patch
+ * the composite editors into the hierarchy.
*/
public void testDirtyOptionalList() {
WorkgroupEditorDriver driver = GWT.create(WorkgroupEditorDriver.class);
Index: user/test/com/google/gwt/emultest/java/util/TreeMapTest.java
===================================================================
--- user/test/com/google/gwt/emultest/java/util/TreeMapTest.java (revision
11026)
+++ user/test/com/google/gwt/emultest/java/util/TreeMapTest.java (working
copy)
@@ -85,7 +85,7 @@
}
@Override
- public final V setValue(V value) {
+ public V setValue(V value) {
throw new UnsupportedOperationException();
}
}
Index: user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java
===================================================================
--- user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java
(revision 11026)
+++ user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java (working
copy)
@@ -527,7 +527,7 @@
* Test interface for multiple wildcard bounds.
*/
public interface MInterface<X> {
- public X echo(X arg);
+ X echo(X arg);
}
/**
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
