On Saturday, June 9, 2012 12:24:43 AM UTC+2, Brian Slesinsky wrote: > > On Fri, Jun 8, 2012 at 1:49 PM, Thomas Broyer <[email protected]> wrote: > > > ServletContainerLauncher is simple enough to be reused here. The > > default implementation based on Jetty 6 could be pushed in a separate > > JAR and the SuperDevMode would warn users if it finds a > > WEB-INF/web.xml, isn't run in -noserver mode, isn't launched with a > > specific ServletContainerLauncher, and the default implementation is > > not found in the classpath. Alternately, it could be bundled in > > gwt-user.jar in the SDK (though not on Maven). > > Okay, I don't know much about it yet, but I think we should do the > experiment. Unlike regular Dev Mode, I think this should be off by > default. How about we add a flag or two? Maybe something like: > > -warDir path/to/my/expanded/warDir > > If you don't supply this flag then it works like it does now (we do > nothing). If it's supplied then we start up a ServerContainer. I > expect we'll need other flags too. >
SGTM > There's currently a directory under each CompileDir called "war", > which contains compiler output. I assume we have to copy that into the > user's warDir somehow, or somehow make the files appear there on the > server? Yeah, this is an issue for people using GWT-RPC currently: https://groups.google.com/d/msg/google-web-toolkit/ZugfWpwnXJs/Rj4sG6PpW_oJ It will also affect ExternalTextResource and the like in ClientBundle, and ImageBundle; and of course resources in the 'public path' of modules and custom generators. It would be great if GeneratorContext could directly generate to both the "war" under the CompileDir *and* the -warDir if provided. If we have multiple modules, do we put them all into the same > warDir? > Could you think of a case where it wouldn't be what the user wants? > Getting Gerrit to work sounds like a good proof of concept. > ;-) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
