[gwt-contrib] Use Node.contains in IE9/Webkit for isOrHasChild (issue1725808)

[stephen . haberman]

Reviewers: jlabanca, tbroyer_gmail.com,


Please review this at http://gwt-code-reviews.appspot.com/1725808/

Affected files:
  M user/src/com/google/gwt/dom/client/DOMImplMozilla.java
  M user/src/com/google/gwt/dom/client/DOMImplStandardBase.java


Index: user/src/com/google/gwt/dom/client/DOMImplMozilla.java
diff --git a/user/src/com/google/gwt/dom/client/DOMImplMozilla.java  
b/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
index  
6b306fcbd51ffdef732d12430606642e4be34b54..f0190bdb1989269b8c195d239a3cab8a39cf218b  
100644
--- a/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
+++ b/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
@@ -30,46 +30,6 @@ class DOMImplMozilla extends DOMImplStandard {
     return -1; // not gecko
   }-*/;

-  /**
-   * Return true if using Gecko 1.9.0 (Firefox 3) or earlier.
-   *
-   * @return true if using Gecko 1.9.0 (Firefox 3) or earlier
-   */
-  private static boolean isGecko190OrBefore() {
-    int geckoVersion = getGeckoVersion();
-    return (geckoVersion != -1) && (geckoVersion <= 1009000);
-  }
-
-  /**
-   * Return true if using Gecko 1.9.1 (Firefox 3.5) or earlier.
-   *
-   * @return true if using Gecko 1.9.1 (Firefox 3.5) or earlier
-   */
-  private static boolean isGecko191OrBefore() {
-    int geckoVersion = getGeckoVersion();
-    return (geckoVersion != -1) && (geckoVersion <= 1009001);
-  }
-
-  /**
-   * Return true if using Gecko 1.9.2 (Firefox 3.6) or earlier.
-   *
-   * @return true if using Gecko 1.9.2 (Firefox 3.6) or earlier
-   */
-  private static boolean isGecko192OrBefore() {
-    int geckoVersion = getGeckoVersion();
-    return (geckoVersion != -1) && (geckoVersion <= 1009002);
-  }
-
-  /**
-   * Return true if using Gecko 2.0.0 (Firefox 4.0) or earlier.
-   *
-   * @return true if using Gecko 2.0.0 (Firefox 4.0) or earlier
-   */
-  private static boolean isGecko2OrBefore() {
-    int geckoVersion = getGeckoVersion();
-    return (geckoVersion != -1) && (geckoVersion < 2000000);
-  }
-
   @Override
   public native void buttonClick(ButtonElement button) /*-{
     var doc = button.ownerDocument;
Index: user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
diff --git a/user/src/com/google/gwt/dom/client/DOMImplStandardBase.java  
b/user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
index  
68aafb616f0a120f1b38edebb78813e69f188d82..5d698f77fbc5a9b10c0dc4a566f8fc5139e5bc8e  
100644
--- a/user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
+++ b/user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
@@ -245,20 +245,6 @@ class DOMImplStandardBase extends DOMImplStandard {
   }-*/;

   @Override
-  public native boolean isOrHasChild(Node parent, Node child) /*-{
-    while (child) {
-      if (parent == child) {
-        return true;
-      }
-      child = child.parentNode;
-      if (child && (child.nodeType != 1)) {
-        child = null;
-      }
-    }
-    return false;
-  }-*/;
-
-  @Override
   public void setScrollLeft(Document doc, int left) {
     // Safari always applies document scrolling to the body element, even  
in
     // strict mode.


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors