Sorry for the delay.
LGTM.

http://gwt-code-reviews.appspot.com/1794803/diff/4001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):

http://gwt-code-reviews.appspot.com/1794803/diff/4001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode144
user/src/com/google/gwt/uibinder/rebind/FieldManager.java:144: * Those
fields are modified every time a template is rendered with the parameter
values.
Maybe add a TODO that indicates that this hack will go away once the
UIBinder generator is split out to handle UIRenderer templates
differently from the UIBinder templates.

http://gwt-code-reviews.appspot.com/1794803/diff/4001/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
(right):

http://gwt-code-reviews.appspot.com/1794803/diff/4001/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java#newcode397
user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java:397: // Sets
initializer to a NOOP. These fields are set from parameters passed to
UiRenderer#render().
Sets initializer to a NOOP --> Sets initializer is a NOOP..

http://gwt-code-reviews.appspot.com/1794803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to