Reviewers: ,
Description:
Add constructors that allow the user to skip wrapping an ImageResource
in an Image. Sometimes it is more convenient to not have to worry about
the Image.
http://code.google.com/p/google-web-toolkit/issues/detail?id=4714
Please review this at http://gwt-code-reviews.appspot.com/1833803/
Affected files:
user/src/com/google/gwt/user/client/ui/PushButton.java
Index: user/src/com/google/gwt/user/client/ui/PushButton.java
===================================================================
--- user/src/com/google/gwt/user/client/ui/PushButton.java (revision 11270)
+++ user/src/com/google/gwt/user/client/ui/PushButton.java (working copy)
@@ -17,6 +17,7 @@
package com.google.gwt.user.client.ui;
import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.resources.client.ImageResource;
/**
* A normal push button with custom styling.
@@ -117,6 +118,36 @@
}
/**
+ * Constructor for {@link PushButton}.
+ *
+ * @param upImageResource image resource for the default(up) face of the
button
+ */
+ public PushButton(ImageResource upImageResource) {
+ super(new Image(upImageResource));
+ }
+
+ /**
+ * Constructor for {@link PushButton}.
+ *
+ * @param upImageResource image resource for the default(up) face of the
button
+ * @param downImageResource image resource for the down face of the
button
+ */
+ public PushButton(ImageResource upImageResource, ImageResource
downImageResource) {
+ super(new Image(upImageResource), new Image(downImageResource));
+ }
+
+ /**
+ * Constructor for {@link PushButton}.
+ *
+ * @param upImageResource image resource for the default(up) face of the
button
+ * @param downImageResource image resource for the down face of the
button
+ * @param handler the click handler
+ */
+ public PushButton(ImageResource upImageResource, ImageResource
downImageResource, ClickHandler handler) {
+ super(new Image(upImageResource), new Image(downImageResource),
handler);
+ }
+
+ /**
* Constructor for <code>PushButton</code>. The supplied text is used to
* construct the default face of the button.
*
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
