Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/1760
Change subject: Emit a warning if (some) incompatible options are used.
......................................................................
Emit a warning if (some) incompatible options are used.
In particular when -XenableClosureCompiler is used story of your compile
reports
are disabled.
The GWT compiler does not keep track of the optimnization performed by the
Closure compiler, hence it lacks the information to produce a report that
matches the
output.
Fixes issue 7475
Change-Id: I0e73b0107c23e54b69b9e648bff05d2135ff0b77
---
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
1 file changed, 10 insertions(+), 0 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
index 042e145..9a84a7f 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
@@ -485,7 +485,13 @@
PermutationResult toReturn =
new PermutationResultImpl(js, permutation,
makeSymbolMap(symbolTable, jsProgram), ranges);
CompilationMetricsArtifact compilationMetrics = null;
+
// TODO: enable this when ClosureCompiler is enabled
+ if (options.isClosureCompilerEnabled() &&
options.isCompilerMetricsEnabled() {
+ logger.log(TreeLogger.WARN, "Incompatible options:
-XenableClosureCompiler and "
+ + "-XcompilerMetric; ignoring -XcompilerMetric.");
+ }
+
if (!options.isClosureCompilerEnabled() &&
options.isCompilerMetricsEnabled()) {
compilationMetrics = new
CompilationMetricsArtifact(permutation.getId());
compilationMetrics.setCompileElapsedMilliseconds(System.currentTimeMillis()
@@ -499,6 +505,10 @@
}
// TODO: enable this when ClosureCompiler is enabled
+ if (options.isClosureCompilerEnabled() && options.isSoycEnabled() {
+ logger.log(TreeLogger.WARN, "Incompatible options:
-XenableClosureCompiler and "
+ + "-compileReport; ignoring -compileReport.");
+ }
if (!options.isClosureCompilerEnabled()) {
toReturn.addArtifacts(makeSoycArtifacts(logger, permutationId,
jprogram, js, sizeBreakdowns,
options.isSoycExtra() ? sourceInfoMaps : null, dependencies,
jjsmap, obfuscateMap,
--
To view, visit https://gwt-review.googlesource.com/1760
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e73b0107c23e54b69b9e648bff05d2135ff0b77
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
