Brian Slesinsky has posted comments on this change.
Change subject: Currently the GWT compiler adds a var declaration for each
catch parameter in a try/catch statement, but this is unneeded according to
the spec, and the Closure compiler will issue errors against it.
......................................................................
Patch Set 1: Code-Review+1
Makes sense. Surprised no unit tests care. Do we check the generated
JavaScript anywhere?
--
To view, visit https://gwt-review.googlesource.com/1810
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05dd0429ec22315d57069046b0139ecce045919e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.