Brian Slesinsky has posted comments on this change.
Change subject: Fixes internal compiler error caused by a null logger
parsing jsni code that was generated by a generator at test time.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
Line 528: public void addRootTypes(TreeLogger logger, Collection<String>
sourceTypeNames)
It seems like it would be cleaner to pass the logger to the constructor and
make it a final field. (It is only constructed in two places and it will be
the same logger.)
--
To view, visit https://gwt-review.googlesource.com/1830
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
