Brian Slesinsky has posted comments on this change.
Change subject: Moves GWTTestCase to
Impl#setUncaughtExceptionHandlerForTest.
......................................................................
Patch Set 3: Code-Review+1
(5 comments)
Looking good. Some javadoc tweaks.
....................................................
File user/src/com/google/gwt/junit/client/GWTTestCase.java
Line 350: * This method is called by the test framework to report
uncaught exceptions. The default
"to report uncaught exceptions" -> "to report uncaught exceptions thrown by
callbacks."
Line 351: * implementation causes test case to be reported as 'failed'
however in some rare situations
...causes the test case to be reported as 'failed.' However, in...
Line 352: * where an uncaught exception is expected then test case may
choose to alter the behavior by
... is expected, a test case...
Line 362: * if (t instanceof ExpectedUmbrellaException) {
...instanceof ExpectedTestException...
Line 373: * already finished before this method is called, the behavior
is undefined.
Maybe replace "the behavior is undefined" with "The reported exception is
currently ignored, but this may change in a future version of GWT."
Maybe add another paragraph.
"If reportUncaughtException() is called multiple times during a test
method, only the first one will be reported. If it's called during a test
method that also throws an exception, the reported exception takes
priority over the thrown exception."
--
To view, visit https://gwt-review.googlesource.com/2190
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
