Brian Slesinsky has posted comments on this change.
Change subject: Moves c.g.gwt.logging to common StackTraceDeobfuscator.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java
Line 125: TestSetValidator.rethrowException(caught);
How about calling reportUncaughtException()? It will go there anyway but
calling it directly means we don't have to wrap the exception. (Similarly
below.)
--
To view, visit https://gwt-review.googlesource.com/2300
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44bee6a3abdf550831f6f9263a8c6e3c807ca063
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
