Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable
& StacktraceDeobfuscator.
......................................................................
Patch Set 2:
(8 comments)
....................................................
Commit Message
Line 9: - Gets rid of dublicate code in junit for deobfuscation of stack
traces
Done
....................................................
File user/src/com/google/gwt/junit/server/JUnitHostImpl.java
Line 171: System.err.println("Cannot deobfuscate stack trace:");
Done
....................................................
File user/test/com/google/gwt/junit/TestResultWithExpectedFailures.java
Line 83: String msg = e + "\n(Asserted exception is reported below
via 'cause by')";
Done
....................................................
File user/test/com/google/gwt/junit/client/DefaultExceptionAsserter.java
Line 30: public void assertException(Throwable throwable, ExpectedFailure
annotation) {
Done
Line 32:
assertTrue(getExceptionMessage(throwable).contains(annotation.withMessage()));
Done. Improved messaging.
....................................................
File user/test/com/google/gwt/junit/client/ExceptionAsserter.java
Line 24: public interface ExceptionAsserter {
Played with different ideas only liked the ExceptionMatcher. But that means
I need to change to contract to return a message instead of throwing an
exception which is quite hassle to implement, so I gave up before. I don't
think it worths to work.
Line 26: void assertException(Throwable throwable, ExpectedFailure
annotation);
Done. (Changed the order)
....................................................
File user/test/com/google/gwt/junit/client/GWTTestCaseTest.java
Line 98: // We loose some type information if class meta data is not
available, setting expected failure
Done
--
To view, visit https://gwt-review.googlesource.com/2290
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1021bc99ac88ea6d9d47c3d23c83e79a896213
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
