Goktug Gokdogan has posted comments on this change.

Change subject: add StringBuffer/Builder.reverse
......................................................................


Patch Set 3:

(1 comment)

....................................................
File user/src/com/google/gwt/core/client/impl/StringBufferImpl.java
Line 46:       buffer[i] = origBuffer[length - 1 - i];
toCharArray copies the string using charAt behind the scenes.
If you use s.charAt(length-1-i) here, you can get rid of the extra copy.


--
To view, visit https://gwt-review.googlesource.com/2431
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to