On Wednesday, April 10, 2013 8:03:41 PM UTC+2, Alex Epshteyn wrote: > > Okay, I found a pretty good solution. Solved the problem by adding a > method isSourceMapsEnabled to CompilationResult, which gets passed all > the way from Link to SelectionScriptLinker. The value is set in Link > via the permutation's property oracles. I tested this and it works > well! > > Now, how can I contribute this patch? Long time user, first time > contributor. I signed the CLA many years ago, but haven't submitted > anything until now. > > Are the instructions on > https://developers.google.com/web-toolkit/makinggwtbetter > still valid? >
Apart from the Rietveld/Gerrit part, they're OK. > I'm a little confused because that document says "Upload the patch to > the Rietveld instance at http://gwt-code-reviews.appspot.com/"; whereas > I'm seeing all the messages in this group coming from a system called > Gerrit at https://gwt-review.googlesource.com/ > Yes, we're switching from SVN and Rietveld to Git and Gerrit, so if you can use Git, please do. Feel free to ask for guidance here if needed. Setting up your Git for use with Gerrit requires a few special invocations so if you have a problem don't hesitate to ask (we'll then use that in our new docs). -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
