Brian Slesinsky has posted comments on this change.
Change subject: Prevent dev mode breakage when lots of jso classes are used.
......................................................................
Patch Set 3:
(3 comments)
....................................................
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
Line 343: return (classId << 16) | memberId;
How hard would it be to bump this to 17? That's the fundamental issue,
right?
....................................................
File dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java
Line 41: private HashMap<Integer, Member> memberByMemberId;
I don't see why you changed this to a HashMap. If we're looking things up
by small non-negative integers allocated starting from zero, it seems like
an ArrayList should work fine?
Line 85: int id = memberById.indexOf(m);
Should we instead assert that the name doesn't exist in the map? When is it
okay to call this method with a name that we already added?
Also, not seeing 'm'. Does this code compile?
--
To view, visit https://gwt-review.googlesource.com/2210
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: James Nelson <ja...@wetheinter.net>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: James Nelson <ja...@wetheinter.net>
Gerrit-Reviewer: John Ahlroos <j...@vaadin.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
