Thomas Broyer has posted comments on this change.
Change subject: Reduce ClassSourceFileComposer memory and time complexity
to O(N)
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
I'm fine with pushing the fix of print("foo\n") to a separate change.
....................................................
File user/src/com/google/gwt/user/rebind/ClassSourceFileComposer.java
Line 163: printWriter.print(s.substring(pos, nl + 1));
Nit: how about:
printWriter.append(s, pos, nl + 1);
or
printWriter.write(s, pos, nl + 1);
I wouldn't count on any gain cpu/memory-wise but I find them slightly more
readable.
--
To view, visit https://gwt-review.googlesource.com/2460
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
