Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2481
Change subject: Changes error messaging in devmode.js.
......................................................................
Changes error messaging in devmode.js.
This change makes sure we show the glass pane in dev mode even the error
function is set via gwt:onLoadErrorFn.
If developer has not whitelisted host url, then GWTTestCase will fail when
executed in manual mode using dev mode. However in Chrome it is not clear
why the test case fails. Only message is:
Failed to load module 'blah'. Please see log for details.
Of course there is no nothing in the logs and dev mode doesn't show the
error in
glass pane as it would normally do because gwt:onLoadErrorFn is set in
junit.html.
It is not an easy to fix it on junit side as the cause is not communicated
back
to error handling function and I don't want to change the contract.
Change-Id: Iee4d0540d843b27623c7b6b9d3702df060a0acbf
---
M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
b/dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
index 647fec4..21f38c5 100644
--- a/dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
+++ b/dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
@@ -318,14 +318,13 @@
}
function pluginConnectionError(codeServer) {
+ __gwt_displayGlassMessage(
+ "Plugin failed to connect to Development Mode server at " +
simpleEscape(codeServer),
+ "Follow the troubleshooting instructions at "
+ + "<a
href='http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM'>"
+
+ "http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM</a>");
if ($errFn) {
$errFn($moduleName);
- } else {
- __gwt_displayGlassMessage(
- "Plugin failed to connect to Development Mode server at " +
simpleEscape(codeServer),
- "Follow the troubleshooting instructions at "
- + "<a
href='http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM'>"
-
+ "http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM</a>");
}
}
--
To view, visit https://gwt-review.googlesource.com/2481
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee4d0540d843b27623c7b6b9d3702df060a0acbf
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
