Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
......................................................................
Patch Set 4:
(1 comment)
As I noted earlier in my comments, I agree with Brian.
With the added removeAllChildren, to get rid of stuff like loading
indicator, all they need to do is this:
RootPanel.get().getElement().removeAllChildren().
It will definitely help to add a javadoc to RootPanel#clear to point out
this use case.
Anyway it is not a big deal either way, so I'm ok with both.
....................................................
File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 311: * {@code getElement().appendChild(...)}.</p>
you don't need to close <p> in javadoc. It works like <br>.
--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
