Thomas Broyer has posted comments on this change.

Change subject: Allow line breaks and other whitespace in jsni method references.
......................................................................


Patch Set 1:

(1 comment)

....................................................
File dev/core/test/com/google/gwt/dev/js/TokenStreamTest.java
Line 69:     assertGoodJsni("@org.group.Foo::bar(\nLorg/group/Foo;)");
I think there should be more tests, of both GoodJsni and BadJsni (spaces in type name, before and after the '::', before and after the '(', in between parameters, before the ')')


--
To view, visit https://gwt-review.googlesource.com/2640
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64426b03f4cde2c84c2faf27a2e38aba4720f401
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Kelly Campbell <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to