Matthew Dempsky has posted comments on this change.
Change subject: Remove dependency of RequestFactory on ASM.
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
Line 216: assert descriptor.charAt(0) == '(';
How about add another assert for the last character being ')', and then the
for loop can stop one character earlier and omit the ')' case? That way we
also reject strings that have a ')' in the middle or don't have one.
....................................................
File
user/src/com/google/web/bindery/requestfactory/vm/InProcessRequestContext.java
Line 104: if (param == Boolean.TYPE) {
Seems like keeping a "private String getDescriptor(Class<?> param)" helper
here would be worthwhile for readability.
--
To view, visit https://gwt-review.googlesource.com/2720
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec08206c60905ccce972b0400f3c1253afa01755
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
