James Nelson has posted comments on this change.
Change subject: Temporarily disable deRPC tests.
......................................................................
Patch Set 2: Code-Review+1
Looks good, but after checking out the tests that are disabled, I've
noticed the only difference is the module xml is setting
gwt.rpc.hijackLegacyInterface to true so the legacy remote service hijacks
the generator to emit deRPC implementations (which appears to not work if
JUnitHostImpl is not a deRPC as well).
Unless we are planning to support the legacy deRPC system, we may want to
consider deleting the com.google.gwt.rpc.RPCSuite module entirely and
making the test cases extend RemoteServiceServlet instead of
HybridServiceServlet. If we are not supporting Hybrid / deRPC, we probably
shouldn't leave test servlets that suggests we do support it.
The only servlets other than the ones commented out that extend
HybridServiceServlet are from a test for a bug that was fixed seven years
ago (in the package "test").
https://code.google.com/p/google-web-toolkit/issues/detail?id=9
--
To view, visit https://gwt-review.googlesource.com/2733
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f439cd60d7f08df2c192ecdc5c6312e6aca1f50
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: James Nelson <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
