Roberto Lublinerman has posted comments on this change.
Change subject: Makes GWT.runAsync to always run async.
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
LGTM
....................................................
File user/src/com/google/gwt/core/client/GWT.java
Line 269: Scheduler.get().scheduleDeferred(new ScheduledCommand() {
This is only used in DevMode right? Otherwise it would break the code
splitter as well.
....................................................
File user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
Line 636: * from the scheduled command, then it will break the code
splitter.
change "will break the code splitter" by "will make the code splitter put
the split point code in the initial fragment"
....................................................
File user/test/com/google/gwt/dev/jjs/test/RunAsyncFailureTest.java
Line 23: import com.google.gwt.core.client.prefetch.RunAsyncCode;
Remove the unused import.
--
To view, visit https://gwt-review.googlesource.com/2770
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia55b41c6978a7d2824ceeb3289dc48fe05bf117b
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
