Thomas Broyer has posted comments on this change.

Change subject: Removes JavaScriptException dependency from c.g.gwt.core.shared.
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

....................................................
File tools/api-checker/config/gwt25_26userApi.conf
Line 99: :user/src/com/google/gwt/core/shared/impl/**\
Is this needed, given that com.google.gwt.core.shared.impl is added to the excludedPackages below?

Maybe only exclude ThrowableTypeResolver here? (if apicheck would otherwise fail)


--
To view, visit https://gwt-review.googlesource.com/2840
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib610bb27cefb3d405e2126417008f4134743e723
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to