Thomas Broyer has posted comments on this change.
Change subject: Fixes ISSUE 7079 - Add support for the newer bindery
HandlerRegistration
......................................................................
Patch Set 2: Code-Review+1
Hmm, so, UiBinder only supports event handlers that extend EventHandler,
and the error message in this case points to GwtEvent (so we can say
UiBinder is tailored for GwtEvent and not the more generic Event), but this
change wants to make it legal for an addXxxHandler(SomeGwtEvent) method to
return a bindery HandlerRegistration (i.e. mixing c.g.g.event and
c.g.web.bindery.event types in the same method).
That sounds weird.
I wonder if it wouldn't be better to either:
* put an error message when we detect
c.g.web.bindery.event.shared.HandlerRegistration saying "did you mean
com.google.gwt.event.shared.HandlerRegistration"
* or fully support c.g.web.bindery.event: mandate "assignable to
c.g.w.b.event.shared.Event", don't look for EventHandler (only "is
interface"), and thus accept any HandlerRegistration.
--
To view, visit https://gwt-review.googlesource.com/1350
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Julien Dramaix <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Julien Dramaix <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Manuel Carrasco Moñino <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
