Manuel Carrasco Moñino has posted comments on this change.

Change subject: Remove early optimization from Precompile.
......................................................................


Patch Set 2: Code-Review+1

I have tested the patch with a couple of large projects and the time difference is not appreciable:

2:35.148s -> 2:29.584s
1:56.687s -> 1:54.328s

Maybe because I'm compiling 2 permutations for these projects. Time is the entire maven process (package) without tests.

The patch does not break anything.

--
To view, visit https://gwt-review.googlesource.com/2280
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26bad5f14735a9283021b53edadc5bde1a659c45
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Manuel Carrasco Moñino <manuel.carrasc...@gmail.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@gwtproject.org>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to