Manuel Carrasco Moñino has posted comments on this change.
Change subject: Cut circular dependency between c.g.g.core.linker and
c.g.g.dev.js
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
LGTM
....................................................
File dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java
Line 81: escape = 'n';
It is a matter not related with this commit, but shouldn't be an
optimization if we replace '\n" with ";" instead of "\\n" so as we save
some bytes in final JS?
We should consider edge cases like ',\n' in js objects, etc, though
Line 109: *
I think code-style has been relaxed, but spaces at the end of the line
should be removed, right?
--
To view, visit https://gwt-review.googlesource.com/1031
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer <[email protected]>
Gerrit-Reviewer: Manuel Carrasco Moñino <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
