Matthew Dempsky has posted comments on this change.
Change subject: Fix module unloading with multiple modules on a page
......................................................................
Patch Set 1:
(Hm, I thought I already posted this as a comment last night.)
I agree this is technically a semantic change from before, but I think the
risk of it actually breaking anything is low. If getEventListener()
returns an object from another module, there's nothing we can actually do
with it since the methods might have been mangled differently. The only
possibly safe thing to do is to compare against null.
RootPanel does limit itself to only just null testing, but then those
actions are also only done for debugging asserts from what I can tell. So
the risk there seems relatively low.
More generally, Roberto and I discussed that perhaps the compiler could
(optionally, and primarily for development/testing) add appropriate
instanceof checks to JSNI return values. Then we could have caught earlier
on that getEventListener() was returning non-EventListener objects contrary
to its method signature.
--
To view, visit https://gwt-review.googlesource.com/2941
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25d9471c1e14756196a11223eadb765ed303a3b4
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
